New recipe to adopt Lombok setter method names by timo-a · Pull Request #632 · openrewrite/rewrite-migrate-java

timo-a · 2024-12-15T19:23:29Z

analogous to feat: normalize effective getter methods #631

probably best to work on that one first and then come back here.

src/main/java/org/openrewrite/java/migrate/lombok/LombokUtils.java

src/test/java/org/openrewrite/java/migrate/lombok/NormalizeSetterTest.java

github-actions

Some suggestions could not be made:

src/main/java/org/openrewrite/java/migrate/lombok/LombokUtils.java
- lines 32-33

github-actions · 2025-02-12T12:30:29Z

src/main/java/org/openrewrite/java/migrate/lombok/NormalizeSetter.java

+import java.util.List;
+import java.util.StringJoiner;


Suggested change

import java.util.List;

import java.util.StringJoiner;

import java.util.List;

src/main/java/org/openrewrite/java/migrate/lombok/NormalizeSetter.java

timtebeek · 2025-04-21T18:22:25Z

The rename suggested here, as well as the other fixes there can likely be applied here as well for consistency

feat: normalize effective getter methods #631

…java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…terTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

src/main/java/org/openrewrite/java/migrate/lombok/AdoptLombokSetterMethodNames.java

…etterMethodNames.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

timtebeek

Great to see! Thanks for bringing parity and applying the feedback left on the Getter PR here as well.

…12.0 to 3.15.0 [skip ci] Bumps [org.openrewrite.recipe:rewrite-migrate-java](https://github.com/openrewrite/rewrite-migrate-java) from 3.12.0 to 3.15.0. Release notes *Sourced from [org.openrewrite.recipe:rewrite-migrate-java's releases](https://github.com/openrewrite/rewrite-migrate-java/releases).* > 3.15.0 > ------ > > What's Changed > -------------- > > * Convert assigning Switch statements to Switch expressions by [`@pdelagrave`](https://github.com/pdelagrave) in [openrewrite/rewrite-migrate-java#795](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/795) > * Convert switch expressions to arrows where possible by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#801](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/801) > * Convert switch cases with returns to returned switch expression by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#802](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/802) > * `ReplaceStreamCollectWithToList` should look at return type by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#803](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/803) > * New recipe to adopt Lombok setter method names by [`@timo-a`](https://github.com/timo-a) in [openrewrite/rewrite-migrate-java#632](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/632) > * refactor: Static imports for Collections and Collectors by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#804](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/804) > * Preserve whitespace in `MigrateCollectionsUnmodifiableList` by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#806](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/806) > * rename settings.local.json to settings.json by [`@zieka`](https://github.com/zieka) in [openrewrite/rewrite-migrate-java#808](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/808) > * The quick fix for the tests for Jaxws Dependencies by [`@steve-aom-elliott`](https://github.com/steve-aom-elliott) in [openrewrite/rewrite-migrate-java#809](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/809) > * Refactor RewriteTest to use defaults method by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#814](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/814) > * Create `is` methods for boolean fields in `LombokValueToRecord` by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#813](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/813) > * Joda-time: Make safe migration optional by [`@amishra-u`](https://github.com/amishra-u) in [openrewrite/rewrite-migrate-java#811](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/811) > * Improve "Add explicit Common Annotations dependencies" in "Migrate to Java 11" by [`@jevanlingen`](https://github.com/jevanlingen) in [openrewrite/rewrite-migrate-java#816](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/816) > * chore(ci): bump actions/checkout from 4 to 5 by [`@dependabot`](https://github.com/dependabot)[bot] in [openrewrite/rewrite-migrate-java#817](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/817) > > **Full Changelog**: <openrewrite/rewrite-migrate-java@v3.14.0...v3.15.0> > > 3.14.1 > ------ > > What's Changed > -------------- > > * OpenRewrite v8.59.1: <https://github.com/openrewrite/rewrite> > > **Full Changelog**: <https://github.com/openrewrite/rewrite-migrate-java> > > 3.14.0 > ------ > > What's Changed > -------------- > > * `NullCheckAsSwitchCase` should only add `null` case if the switch is exhaustive by [`@Jenson3210`](https://github.com/Jenson3210) in [openrewrite/rewrite-migrate-java#769](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/769) > * Let all change-to-var recipes use a created var-Identifier instead of using a JavaTemplate by [`@jevanlingen`](https://github.com/jevanlingen) in [openrewrite/rewrite-migrate-java#793](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/793) > * Fix NPE in IteratorNext recipe when iterator() has no explicit receiver by [`@jkschneider`](https://github.com/jkschneider) in [openrewrite/rewrite-migrate-java#796](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/796) > * `LombokValueToRecord` should rewrite method references too by [`@holgpar`](https://github.com/holgpar) in [openrewrite/rewrite-migrate-java#469](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/469) > * Update test expectations to now finish idempotent `ChangeTagAttribute` in a single cycle by [`@pdelagrave`](https://github.com/pdelagrave) in [openrewrite/rewrite-migrate-java#797](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/797) > * refactor: Unwrap else block after return or throw statement by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#798](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/798) > > **Full Changelog**: <openrewrite/rewrite-migrate-java@v3.13.0...v3.14.0> > > 3.13.0 > ------ > > What's Changed > -------------- > > * refactor: org.openrewrite.mavencentral by [`@Laurens-W`](https://github.com/Laurens-W) in [openrewrite/rewrite-migrate-java#778](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/778) > * Do not add explicit `Record` class import if using `var` keyword by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#781](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/781) > * Correct groupId for `jakarta.annotation:jakarta.annotation-api` upgrade by [`@steve-aom-elliott`](https://github.com/steve-aom-elliott) in [openrewrite/rewrite-migrate-java#784](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/784) > * Keep `jakarta.annotation-api` dependency when moving to Jakarta with Spring Boot project and Jakarta annotations are used by [`@jevanlingen`](https://github.com/jevanlingen) in [openrewrite/rewrite-migrate-java#782](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/782) > * Add Bouncy Castle upgrade recipe for Java < 8 by [`@pdelagrave`](https://github.com/pdelagrave) in [openrewrite/rewrite-migrate-java#790](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/790) > * Fix `LombokValToFinalVar` in loops by [`@MBoegers`](https://github.com/MBoegers) in [openrewrite/rewrite-migrate-java#768](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/768) > * Replace JavaTemplate by a `var` identifier element for UseVarForGenericsConstructors recipe by [`@jevanlingen`](https://github.com/jevanlingen) in [openrewrite/rewrite-migrate-java#789](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/789) > * Add missing type table entries by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#792](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/792) > * Migrate Lombok's `@__` syntax to `onX_` for Java 8+ by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#794](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/794) ... (truncated) Commits * [`f65c067`](openrewrite/rewrite-migrate-java@f65c067) Restore `UpdateJakartaAnnotations2` as a deprecated placeholder * [`aa973e9`](openrewrite/rewrite-migrate-java@aa973e9) chore(ci): bump actions/checkout from 4 to 5 ([#817](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/817)) * [`a6a509e`](openrewrite/rewrite-migrate-java@a6a509e) Improve "Add explicit Common Annotations dependencies" in "Migrate to Java 11... * [`cbe5ca5`](openrewrite/rewrite-migrate-java@cbe5ca5) [Auto] SDKMAN! Java candidates as of 2025-08-11T1018 * [`180b215`](openrewrite/rewrite-migrate-java@180b215) Revert "Joda-time: Make safe migration optional ([#811](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/811))" * [`531270b`](openrewrite/rewrite-migrate-java@531270b) Joda-time: Make safe migration optional ([#811](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/811)) * [`9f029e3`](openrewrite/rewrite-migrate-java@9f029e3) Create `is` methods for boolean fields in `LombokValueToRecord` ([#813](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/813)) * [`bc6f9dc`](openrewrite/rewrite-migrate-java@bc6f9dc) Allow BouncyCastleTest to match in any order * [`eef26e4`](openrewrite/rewrite-migrate-java@eef26e4) Refactor RewriteTest to use defaults method ([#814](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/814)) * [`d9674d1`](openrewrite/rewrite-migrate-java@d9674d1) Delegate from `RemoveIllegalSemicolons` to `RemoveExtraSemicolons` * Additional commits viewable in [compare view](openrewrite/rewrite-migrate-java@v3.12.0...v3.15.0) [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=org.openrewrite.recipe:rewrite-migrate-java&package-manager=maven&previous-version=3.12.0&new-version=3.15.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

github-actions bot reviewed Dec 15, 2024

View reviewed changes

src/main/java/org/openrewrite/java/migrate/lombok/LombokUtils.java Outdated Show resolved Hide resolved

src/main/java/org/openrewrite/java/migrate/lombok/LombokUtils.java Outdated Show resolved Hide resolved

github-actions bot reviewed Dec 15, 2024

View reviewed changes

timtebeek assigned timo-a Dec 22, 2024

timtebeek added the recipe Recipe requested label Dec 22, 2024

timo-a force-pushed the lombok/normalize-setter branch from 2e4e61d to 1024a1e Compare January 1, 2025 19:15

timtebeek mentioned this pull request Jan 5, 2025

feat: use lombok @NoArgsConstructor annotation #645

Merged

3 tasks

timtebeek added the lombok label Jan 17, 2025

github-actions bot reviewed Feb 12, 2025

View reviewed changes

timo-a force-pushed the lombok/normalize-setter branch from 52dd329 to 1486b98 Compare February 16, 2025 16:23

github-actions bot reviewed Apr 20, 2025

View reviewed changes

src/main/java/org/openrewrite/java/migrate/lombok/NormalizeSetter.java Outdated Show resolved Hide resolved

timo-a and others added 19 commits July 2, 2025 21:00

migrate recipes as-is

cbd4deb

fix year in license

eb2ccca

bring back original helper methods

8d8ad1d

minor polish

316657f

remove line in recipe spec

28b76ff

Update src/main/java/org/openrewrite/java/migrate/lombok/LombokUtils.…

04a78bc

…java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/main/java/org/openrewrite/java/migrate/lombok/LombokUtils.…

ccf978d

…java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/test/java/org/openrewrite/java/migrate/lombok/NormalizeSet…

daecba7

…terTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix build

45be826

fix build

783df6d

markdown and comments

28946ff

support no field access

a1fab56

Inline MethodRecorder & rename list of methods not renamed

772ccba

Remove unnecessary packages

dfbcb60

Capture current behavior with a running test

23a98d3

fix test

29cf350

Apply suggestions from code review (of getter pr)

73f2732

Group the tests that expect no change

ca9f973

Use early returns in isEffectivelySetter

31659ef

timo-a added 6 commits July 2, 2025 21:00

Adopt TypeUtils.isOverride

37be475

Use MethodMatcher.methodPattern(method)

e99aa5f

UsegetTypesInUse().getDeclaredMethods()

080aa67

Expect to fail for a case not covered yet

ee573ca

Inline MethodAcc

cc6e71f

refactor: rename to sth. less ambiguous

54502e8

timo-a force-pushed the lombok/normalize-setter branch from 6c8d03e to 54502e8 Compare July 2, 2025 19:00

github-actions bot reviewed Jul 2, 2025

View reviewed changes

src/main/java/org/openrewrite/java/migrate/lombok/AdoptLombokSetterMethodNames.java Outdated Show resolved Hide resolved

timo-a marked this pull request as ready for review July 2, 2025 19:04

timo-a changed the title ~~[DRAFT]: feat: normalize effective setter methods~~ feat: normalize effective setter methods Jul 2, 2025

timo-a changed the title ~~feat: normalize effective setter methods~~ New recipe to adopt Lombok setter method names Jul 2, 2025

timtebeek self-requested a review July 3, 2025 17:12

timtebeek moved this from In Progress to Ready to Review in OpenRewrite Jul 3, 2025

Merge branch 'main' into lombok/normalize-setter

afa84e7

github-actions bot reviewed Jul 26, 2025

View reviewed changes

src/main/java/org/openrewrite/java/migrate/lombok/AdoptLombokSetterMethodNames.java Outdated Show resolved Hide resolved

timtebeek and others added 2 commits July 26, 2025 20:08

Update src/main/java/org/openrewrite/java/migrate/lombok/AdoptLombokS…

00c3727

…etterMethodNames.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Minimize changes with Getter equivalent

4fc323a

timtebeek approved these changes Jul 27, 2025

View reviewed changes

timtebeek merged commit ed02764 into openrewrite:main Jul 27, 2025
2 checks passed

github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Jul 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New recipe to adopt Lombok setter method names#632

New recipe to adopt Lombok setter method names#632
timtebeek merged 28 commits intoopenrewrite:mainfrom
timo-a:lombok/normalize-setter

timo-a commented Dec 15, 2024 •

edited by timtebeek

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot Feb 12, 2025

Uh oh!

Uh oh!

timtebeek commented Apr 21, 2025

Uh oh!

Uh oh!

Uh oh!

timtebeek left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	import java.util.List;
	import java.util.StringJoiner;
	import java.util.List;

Conversation

timo-a commented Dec 15, 2024 • edited by timtebeek Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

timtebeek commented Apr 21, 2025

Uh oh!

Uh oh!

Uh oh!

timtebeek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

timo-a commented Dec 15, 2024 •

edited by timtebeek

Loading